[BR-1794]: Add server error retry with exponential backoff #1848
+220
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrerox
requested review from
a team,
CandelR and
larryrider
as code owners
terrerox
changed the title
Deploying drive-web with
|
| Latest commit: |
83dcf5f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1ae87a65.drive-web.pages.dev |
| Branch Preview URL: | https://feature-retry-with-backoff-s.drive-web.pages.dev |
- Extend retry mechanism to handle server errors (5xx), CORS errors, and network failures with exponential backoff - Add RetryReason enum to distinguish between rate limit and server error retries - Update onRetry callbacks to include retry reason parameter - Add HTTP status codes for server errors (500, 502, 503, 504) to constants - Add CORS to ErrorMessages enum - Rename retry-with-rate-limit to retry-with-backoff to reflect broader functionality - Improve test coverage and descriptions
terrerox
force-pushed
the
feature/retry-with-backoff-server-errors
branch
from
c65f899 to
31b200e
Compare
terrerox
changed the title
|
| it('when server error persists then throws after max retries', async () => { | ||
| const mockFn = vi.fn().mockRejectedValue({ status: 500, message: 'Server Error' }); | ||
|
|
||
| await expect(retryWithBackoff(mockFn, { maxRetries: 2 })).rejects.toEqual({ status: 500, message: 'Server Error' }); |
Contributor
There was a problem hiding this comment.
Isn't maxRetries=5 by default?
Contributor
|
LGTM. Math is what everyone else uses for computing time variation, even if Sonar complains. Btw, @CandelR @larry-internxt Maybe it's easier and cleaner if we use a third-party library for retries? |
TamaraFinogina
approved these changes
Feb 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For more context please see this comment.
exponential backoff
Related Issues
Related Pull Requests
Checklist
Testing Process
Additional Notes